Skip to content

update-test: more improvements.#9028

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:update-test-tweaks
Nov 4, 2020
Merged

update-test: more improvements.#9028
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:update-test-tweaks

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Nov 2, 2020

  • Explain why HOMEBREW_UPDATE_TEST is set and what it does.
  • Avoid auto-updating (this should already be not happening but let's make sure).
  • Set environment variables to ensure we're testing the default update behaviour (rather than deferring to user configuration).
  • Use HOMEBREW_BREW_GIT_REMOTE as well as setting git config remote.origin.url ourselves.
  • Run brew help quietly first to hide irrelevant portable Ruby output.
  • Run brew update --verbose --debug to get even more output on failure.

Fixes #8979

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

- Explain why `HOMEBREW_UPDATE_TEST` is set and what it does.
- Avoid auto-updating (this should already be not happening but let's
  make sure).
- Set environment variables to ensure we're testing the default update
  behaviour (rather than deferring to user configuration).
- Use `HOMEBREW_BREW_GIT_REMOTE` as well as setting
  `git config remote.origin.url` ourselves.
- Run `brew help` quietly first to hide irrelevant portable Ruby output.
- Run `brew update --verbose --debug` to get even more output on
  failure.

Fixes #8979
@MikeMcQuaid MikeMcQuaid merged commit 3e36285 into Homebrew:master Nov 4, 2020
@MikeMcQuaid MikeMcQuaid deleted the update-test-tweaks branch November 4, 2020 13:58
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew CI has general failures

2 participants