Skip to content

Unify and use Git username/email/GPG handling.#9030

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:gpg-tweaks
Nov 2, 2020
Merged

Unify and use Git username/email/GPG handling.#9030
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:gpg-tweaks

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

We're using essentially the same logic to setup Git for committing in multiple places but the way we're doing so is inconsistent. Moved to using two shared utility methods and use them consistently.

Without this brew pr-pull failed consistently due to being unable to find gpg when it ran brew bottle.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

We're using essentially the same logic to setup Git for committing in
multiple places but the way we're doing so is inconsistent. Moved to
using two shared utility methods and use them consistently.
@MikeMcQuaid MikeMcQuaid merged commit 05bbb41 into Homebrew:master Nov 2, 2020
@MikeMcQuaid MikeMcQuaid deleted the gpg-tweaks branch November 2, 2020 14:09
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants