Unify and use Git username/email/GPG handling.#9030
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Nov 2, 2020
MikeMcQuaid:gpg-tweaks
Merged
Unify and use Git username/email/GPG handling.#9030MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:gpg-tweaks
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:gpg-tweaks
Conversation
We're using essentially the same logic to setup Git for committing in multiple places but the way we're doing so is inconsistent. Moved to using two shared utility methods and use them consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using essentially the same logic to setup Git for committing in multiple places but the way we're doing so is inconsistent. Moved to using two shared utility methods and use them consistently.
Without this
brew pr-pullfailed consistently due to being unable to findgpgwhen it ranbrew bottle.brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?