Skip to content

README: update 1Password image#9034

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
EricFromCanada:1password-image
Nov 3, 2020
Merged

README: update 1Password image#9034
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
EricFromCanada:1password-image

Conversation

@EricFromCanada
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

The makers of 1Password seem to have dropped both the AgileBits name and the image we were linking to, so this updates the image and text accordingly.

Copy link
Copy Markdown
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@MikeMcQuaid MikeMcQuaid merged commit 9115ef7 into Homebrew:master Nov 3, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @EricFromCanada!

@EricFromCanada EricFromCanada deleted the 1password-image branch November 3, 2020 15:11
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants