Skip to content

list: fix flag handling. #9035

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:ls-flags
Nov 3, 2020
Merged

list: fix flag handling. #9035
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:ls-flags

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Nov 3, 2020

Fix -1 and other flags so they're handled correctly with casks. Use the "right" exceptions for declaring invalid combinations and change their parent class so that --help is printed nicely too.

Fixes #9033

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fix `-1` and other flags so they're handled correctly with casks. Use
the "right" exceptions for declaring invalid combinations and change
their parent class so that `--help` is printed nicely too.

Fixes #9033
@MikeMcQuaid MikeMcQuaid changed the title list: fix -1 handling. list: fix flag handling. Nov 3, 2020
@MikeMcQuaid MikeMcQuaid merged commit dbdf7cf into Homebrew:master Nov 3, 2020
@MikeMcQuaid MikeMcQuaid deleted the ls-flags branch November 3, 2020 15:00
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew list -l produces short output for casks, doesn't print totals as claimed in help

2 participants