Skip to content

Allow casks to depend on ARM#9068

Merged
fxcoudert merged 2 commits intoHomebrew:masterfrom
fxcoudert:bs2
Nov 6, 2020
Merged

Allow casks to depend on ARM#9068
fxcoudert merged 2 commits intoHomebrew:masterfrom
fxcoudert:bs2

Conversation

@fxcoudert
Copy link
Copy Markdown
Member

Fix a second failure on Big Sur ARM (#9066):

  2) Satisfy Dependencies and Requirements depends_on arch when satisfied does not raise an error
     Failure/Error: expect { install }.not_to raise_error
     
       expected no Exception, got #<Cask::CaskError: Cask with-depends-on-arch depends on hardware architecture being one of [{:type=>:intel, :bits=>64}], but you are running {:type=>:arm, :bits=>64}> with backtrace:
         # ./cask/installer.rb:272:in `arch_dependencies'
         # ./cask/installer.rb:251:in `satisfy_dependencies'
         # ./cask/installer.rb:66:in `fetch'
         # ./cask/installer.rb:94:in `install'
         # ./test/cask/depends_on_spec.rb:8:in `block (2 levels) in <top (required)>'
         # ./test/cask/depends_on_spec.rb:73:in `block (5 levels) in <top (required)>'
         # ./test/cask/depends_on_spec.rb:73:in `block (4 levels) in <top (required)>'
         # ./test/support/helper/spec/shared_context/homebrew_cask.rb:52:in `block (2 levels) in <top (required)>'
         # ./test/spec_helper.rb:194:in `block (3 levels) in <top (required)>'
         # ./test/spec_helper.rb:193:in `block (2 levels) in <top (required)>'
         # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
         # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
         # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
         # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
         # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
         # ./vendor/bundle/ruby/2.6.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'
     # ./test/cask/depends_on_spec.rb:73:in `block (4 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/homebrew_cask.rb:52:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:194:in `block (3 levels) in <top (required)>'
     # ./test/spec_helper.rb:193:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'

Comment thread Library/Homebrew/cask/dsl/depends_on.rb Outdated
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@fxcoudert fxcoudert merged commit 60afa5f into Homebrew:master Nov 6, 2020
@fxcoudert fxcoudert deleted the bs2 branch November 6, 2020 14:59
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants