Skip to content

Add support for arm64 architecture requirement#9076

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
EricFromCanada:arm-arch-requirement
Nov 9, 2020
Merged

Add support for arm64 architecture requirement#9076
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
EricFromCanada:arm-arch-requirement

Conversation

@EricFromCanada
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Allow formulae to specify depends_on arch: :arm64 for ARM-specific packages.

@fxcoudert
Copy link
Copy Markdown
Member

  • Do we support 32-bit ARM?
  • If :intel means either :i386 or :x86_64, should :arm mean either :arm32 or :arm64?

@EricFromCanada
Copy link
Copy Markdown
Member Author

* Do we support 32-bit ARM?

Not for macOS, obviously, but it seems we do on Linux, in theory anyway.

* If `:intel` means either `:i386` or `:x86_64`, should `:arm` mean either `:arm32` or `:arm64`?

Yes. My guess is that there won't be many ARM-only packages that compile only on 64-bit ARM and not 32-bit; only those would be marked :arm64, any that run on either would be marked :arm. Willing to take a wait-and-see approach here.

@MikeMcQuaid MikeMcQuaid merged commit 5b75133 into Homebrew:master Nov 9, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @EricFromCanada!

@EricFromCanada EricFromCanada deleted the arm-arch-requirement branch November 9, 2020 15:30
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants