Skip to content

inreplace: fix typecheck error#9079

Merged
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:inreplace-typecheck
Nov 8, 2020
Merged

inreplace: fix typecheck error#9079
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:inreplace-typecheck

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

@jonchang jonchang commented Nov 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

With runtime type checking enabled, inreplace "foo", "bar", libexec fails in formulae. Seen when building Homebrew/homebrew-core#64347 from source.

@jonchang jonchang merged commit fd47fd8 into Homebrew:master Nov 8, 2020
@jonchang jonchang deleted the inreplace-typecheck branch November 8, 2020 13:07
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants