Skip to content

Run brew style on all cask taps instead of running brew cask style.#9101

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:cask-style
Nov 11, 2020
Merged

Run brew style on all cask taps instead of running brew cask style.#9101
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:cask-style

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Nov 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Should prevent CI failures caused by new RuboCops. See Homebrew/homebrew-cask#92322.

Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
@reitermarkus reitermarkus merged commit 9e5555b into Homebrew:master Nov 11, 2020
@reitermarkus reitermarkus deleted the cask-style branch November 11, 2020 08:01
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants