cleanup.rb: ensure cache exists before touching .cleaned#9138
Merged
EricFromCanada merged 1 commit intoHomebrew:masterfrom Nov 15, 2020
Merged
cleanup.rb: ensure cache exists before touching .cleaned#9138EricFromCanada merged 1 commit intoHomebrew:masterfrom
EricFromCanada merged 1 commit intoHomebrew:masterfrom
Conversation
5 tasks
fxcoudert
approved these changes
Nov 15, 2020
Member
|
Good catch, thanks @EricFromCanada! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Make sure that HOMEBREW_CACHE exists before creating the
.cleanedfile. Might fix occasional "Error: No such file or directory @ rb_sysopen - /Users/brew/Library/Caches/Homebrew/.cleaned" errors for bottle builds involving lots of dependents. (xref #5510)One might note that in the aforelinked job, only the Mojave runner was repeatedly deciding to run
Formulae#cleanup_during!after every dependent after a certain point, which suggests that something's awry with the free space detection on that OS or runner.