Skip to content

cleanup.rb: ensure cache exists before touching .cleaned#9138

Merged
EricFromCanada merged 1 commit intoHomebrew:masterfrom
EricFromCanada:cache-path-cleaned
Nov 15, 2020
Merged

cleanup.rb: ensure cache exists before touching .cleaned#9138
EricFromCanada merged 1 commit intoHomebrew:masterfrom
EricFromCanada:cache-path-cleaned

Conversation

@EricFromCanada
Copy link
Copy Markdown
Member

@EricFromCanada EricFromCanada commented Nov 14, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Make sure that HOMEBREW_CACHE exists before creating the .cleaned file. Might fix occasional "Error: No such file or directory @ rb_sysopen - /Users/brew/Library/Caches/Homebrew/.cleaned" errors for bottle builds involving lots of dependents. (xref #5510)

One might note that in the aforelinked job, only the Mojave runner was repeatedly deciding to run Formulae#cleanup_during! after every dependent after a certain point, which suggests that something's awry with the free space detection on that OS or runner.

@EricFromCanada EricFromCanada merged commit 82e1b27 into Homebrew:master Nov 15, 2020
@EricFromCanada EricFromCanada deleted the cache-path-cleaned branch November 15, 2020 14:17
@MikeMcQuaid
Copy link
Copy Markdown
Member

Good catch, thanks @EricFromCanada!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants