Skip to content

audit: don't error on old OS X versions#9141

Merged
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:old-macos-audits
Nov 15, 2020
Merged

audit: don't error on old OS X versions#9141
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:old-macos-audits

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

Some formulae are old enough to start taking driving lessons. Don't fail audits when the git history reaches into pre-history causing errors like:

==> brew audit viennacl --online --git --skip-style
==> FAILED
Error: unknown or unsupported macOS version: :snow_leopard

https://github.com/Homebrew/homebrew-core/runs/1401166825?check_suite_focus=true

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@jonchang jonchang merged commit 63b03fb into Homebrew:master Nov 15, 2020
@jonchang jonchang deleted the old-macos-audits branch November 15, 2020 09:51
@MikeMcQuaid
Copy link
Copy Markdown
Member

@jonchang Could you revert this and add this exception to

IGNORED_EXCEPTIONS = [
ArgumentError, NameError, SyntaxError, TypeError,
FormulaSpecificationError, FormulaValidationError,
ErrorDuringExecution, LoadError, MethodDeprecatedError
].freeze
instead? Thanks!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants