Skip to content

Conversation

@MikeMcQuaid
Copy link
Member

This should hopefully avoid getting more issues about this.

@BrewTestBot
Copy link
Contributor

Review period will end on 2020-12-08 at 15:08:10 UTC.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Dec 7, 2020

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 7, 2020
@MikeMcQuaid MikeMcQuaid merged commit f5f50fe into Homebrew:master Dec 7, 2020
@MikeMcQuaid MikeMcQuaid deleted the no-shallow-clone-clarify branch December 7, 2020 16:05
@rgant
Copy link
Contributor

rgant commented Dec 9, 2020

Those two command are super similar looking. It would be better if they were highlighted as different commands.

@MikeMcQuaid
Copy link
Member Author

@rgant We'll review a PR of your alternate proposal.

@rgant
Copy link
Contributor

rgant commented Dec 10, 2020

Done: #9501

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants