Skip to content

Add audit for livecheck in casks.#9541

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:audit-livecheck
Dec 15, 2020
Merged

Add audit for livecheck in casks.#9541
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:audit-livecheck

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Dec 14, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Check if casks with livecheck blocks have a version and if that version is the same as returned by the livecheck.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-15 at 14:24:52 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 14, 2020
@reitermarkus reitermarkus force-pushed the audit-livecheck branch 2 times, most recently from cd380dd to 9c734d2 Compare December 14, 2020 14:31
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 15, 2020
@reitermarkus reitermarkus merged commit d81e900 into Homebrew:master Dec 15, 2020
@reitermarkus reitermarkus deleted the audit-livecheck branch December 15, 2020 15:19
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants