Improve legacy symlink migration.#992
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Sep 17, 2016
MikeMcQuaid:migrate-legacy-symlinks-harder
Merged
Improve legacy symlink migration.#992MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:migrate-legacy-symlinks-harder
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:migrate-legacy-symlinks-harder
Conversation
Read the old symlinks and migrate them across rather than assuming a unlink/link will work fine (as users have conflicts.)
zmwangx
reviewed
Sep 17, 2016
| pin = FormulaPin.new(formula) | ||
| pin.unpin | ||
| pin.pin_at(pin_version) | ||
| legacy_pinned_kegs.children.each do |link| |
Contributor
There was a problem hiding this comment.
Feature inparity in this block?
Member
Author
There was a problem hiding this comment.
We cannot recover if this symlink is corrupted.
MikeMcQuaid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Too many users are in an intermediate state otherwise which cannot be resolved. Read the old symlinks and migrate them across rather than assuming a unlink/link will work fine (as users have conflicts.)
References #991
Fixes Homebrew/homebrew-core#4926
Fixes #994
CC @zmwangx @ilovezfs @UniqMartin