Skip to content

Conversation

@alexreg
Copy link
Contributor

@alexreg alexreg commented Mar 18, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 18, 2025
@chenrui333

This comment was marked as resolved.

@alexreg
Copy link
Contributor Author

alexreg commented Mar 20, 2025

@chenrui333 Cheers. That should be fixed now.

@alexreg alexreg force-pushed the rofi branch 2 times, most recently from 943bfbc to f1d7034 Compare March 25, 2025 01:10
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 20, 2025
@github-actions github-actions bot removed the stale No recent activity label Apr 22, 2025
@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label May 2, 2025
@chenrui333
Copy link
Member

still missing the linkage declaration?

rofi: update glib dep

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Member

@alexreg, thanks for your contribution to Homebrew-core! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

:shipit: @chenrui333 has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 2, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 2, 2025 17:33
@BrewTestBot BrewTestBot added this pull request to the merge queue May 2, 2025
Merged via the queue into Homebrew:master with commit f60341a May 2, 2025
14 checks passed
@alexreg alexreg deleted the rofi branch May 2, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants