Skip to content

Comments

mesheryctl 0.8.51#214947

Closed
l5io wants to merge 1 commit intoHomebrew:masterfrom
l5io:update-mesheryctl.rb-1742579858
Closed

mesheryctl 0.8.51#214947
l5io wants to merge 1 commit intoHomebrew:masterfrom
l5io:update-mesheryctl.rb-1742579858

Conversation

@l5io
Copy link
Contributor

@l5io l5io commented Mar 21, 2025

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Mar 21, 2025
@chenrui333
Copy link
Member

panic: runtime error: invalid memory address or nil pointer dereference
  [signal SIGSEGV: segmentation violation code=0x2 addr=0x48 pc=0x10272a48c]
  
  goroutine 1 [running]:
  github.com/layer5io/meshery/mesheryctl/internal/cli/root/registry.setupRegistryLogger()
  	github.com/layer5io/meshery/mesheryctl/internal/cli/root/registry/registry.go:65 +0x9c
  github.com/spf13/cobra.(*Command).preRun(...)
  	github.com/spf13/cobra@v1.9.1/command.go:1049
  github.com/spf13/cobra.(*Command).execute(0x1058e0720, {0x1[400](https://github.com/Homebrew/homebrew-core/actions/runs/13997947530/job/39199813287?pr=214947#step:3:401)031c810, 0x1, 0x1})
  	github.com/spf13/cobra@v1.9.1/command.go:959 +0x418
  github.com/spf13/cobra.(*Command).ExecuteC(0x1058e09e0)
  	github.com/spf13/cobra@v1.9.1/command.go:1148 +0x350
  github.com/spf13/cobra.(*Command).Execute(...)
  	github.com/spf13/cobra@v1.9.1/command.go:1071
  github.com/layer5io/meshery/mesheryctl/internal/cli/root.Execute()
  	github.com/layer5io/meshery/mesheryctl/internal/cli/root/root.go:86 +0x58
  main.main()
  	github.com/layer5io/meshery/mesheryctl/cmd/mesheryctl/main.go:26 +0x1c
  Error: Failure while executing; `\{\"SHELL\"=\>\"bash\"\} /opt/homebrew/Cellar/mesheryctl/0.8.51/bin/mesheryctl completion bash` exited with 2. Here's the output:

@chenrui333 chenrui333 added the build failure CI fails while building the software label Mar 21, 2025
@stefanb stefanb added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Mar 23, 2025
@stefanb stefanb force-pushed the update-mesheryctl.rb-1742579858 branch from 6b17062 to ed297ed Compare March 23, 2025 08:03
@stefanb
Copy link
Member

stefanb commented Mar 24, 2025

Works on my machine™:

$ git describe --tag --always --dirty
v0.8.51
$  CGO_ENABLED=0 go build -o=mesheryctlbin ./mesheryctl/cmd/mesheryctl/
$  ./mesheryctlbin completion bash | head
# bash completion for mesheryctl                           -*- shell-script -*-

__mesheryctl_debug()
{
    if [[ -n ${BASH_COMP_DEBUG_FILE:-} ]]; then
        echo "$*" >> "${BASH_COMP_DEBUG_FILE}"
    fi
}

# Homebrew on Macs have version 1.3 of bash-completion which doesn't include

🤔

@stefanb
Copy link
Member

stefanb commented Mar 25, 2025

Superseded by

@stefanb stefanb closed this Mar 25, 2025
@stefanb stefanb added the superseded PR was replaced by another PR label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants