Skip to content

Conversation

@chenrui333
Copy link
Member

snappy 1.2.2


retry #216761

@chenrui333 chenrui333 added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels May 2, 2025
@chenrui333 chenrui333 mentioned this pull request May 2, 2025
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the bump-snappy-1.2.2 branch from f8d7b35 to 699ff23 Compare May 2, 2025 23:44
@samumbach
Copy link
Contributor

samumbach commented May 12, 2025

UPDATE 20250514: Opened PR #223429 including this patch to enable RTTI.

Instead of removing the patch for the snappy formula, I think it needs to be updated to make sure RTTI is enabled. The following patch worked for me locally:

...
__END__
diff --git a/CMakeLists.txt b/CMakeLists.txt
index cd71a47..ef040d1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -51,10 +51,6 @@ if(MSVC)
   string(REGEX REPLACE "/EH[a-z]+" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHs-c-")
   add_definitions(-D_HAS_EXCEPTIONS=0)
-
-  # Disable RTTI.
-  string(REGEX REPLACE "/GR" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /GR-")
 else(MSVC)
   # Use -Wall for clang and gcc.
   if(NOT CMAKE_CXX_FLAGS MATCHES "-Wall")
@@ -81,10 +77,6 @@ else(MSVC)
   # Disable C++ exceptions.
   string(REGEX REPLACE "-fexceptions" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")
-
-  # Disable RTTI.
-  string(REGEX REPLACE "-frtti" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")
 endif(MSVC)

 # BUILD_SHARED_LIBS is a standard CMake variable, but we declare it here to make

See also macos-powerpc/powerpc-ports@c3bfb26#diff-4d3d8c75e8cd876af04bf35d3322ed7af85b75ca5e368a251ab4e82fb0ea51de

@samumbach samumbach mentioned this pull request May 14, 2025
6 tasks
@daeho-ro daeho-ro closed this May 18, 2025
@github-actions github-actions bot deleted the bump-snappy-1.2.2 branch May 18, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants