-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
capnp: compile with C++20 standard level #222339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
c630662 to
68d5a32
Compare
|
Any reasons why this change is needed? |
|
Building a project (Lix package manager) that uses kj coroutines without this change fails with linker errors because the coroutine classes aren't compiled. https://github.com/capnproto/capnproto/blob/release-1.1.0/c%2B%2B/src/kj/async-prelude.h#L36-L40 |
|
Why not just change the CMakeList file? |
|
Is that easier to patch than just adding arguments to CMake? I don't think I understand what you mean. |
68d5a32 to
76fd4ea
Compare
|
If this is crucial, then the changes go to upstream and apply the original file. But you did it from homebrew and so I ask a question 😅 |
|
Upstream now already requires corouties and fails the build otherwise instead of not compiling the classes, it's just not in a release yet: capnproto/capnproto@3cbd744 |
then maybe add a code comment to remove it in the next release? otherwise should be good to go. |
76fd4ea to
5d5929c
Compare
5d5929c to
6fc1d46
Compare
6fc1d46 to
900ab8e
Compare
capnp silently doesn't compile parts of the code when compiled with the default standard level.
900ab8e to
a20397e
Compare
|
Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
capnp silently doesn't compile parts of the code when compiled with the default standard level.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?