Skip to content

Conversation

@dblsaiko
Copy link
Contributor

@dblsaiko dblsaiko commented May 3, 2025

capnp silently doesn't compile parts of the code when compiled with the default standard level.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@dblsaiko dblsaiko force-pushed the push-tzvzosroylvl branch from c630662 to 68d5a32 Compare May 3, 2025 21:26
@botantony
Copy link
Member

Any reasons why this change is needed?

@dblsaiko
Copy link
Contributor Author

dblsaiko commented May 3, 2025

Building a project (Lix package manager) that uses kj coroutines without this change fails with linker errors because the coroutine classes aren't compiled.

https://github.com/capnproto/capnproto/blob/release-1.1.0/c%2B%2B/src/kj/async-prelude.h#L36-L40

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 4, 2025
@daeho-ro
Copy link
Member

daeho-ro commented May 4, 2025

Why not just change the CMakeList file?

@dblsaiko
Copy link
Contributor Author

dblsaiko commented May 4, 2025

Is that easier to patch than just adding arguments to CMake? I don't think I understand what you mean.

@dblsaiko dblsaiko force-pushed the push-tzvzosroylvl branch from 68d5a32 to 76fd4ea Compare May 4, 2025 09:50
@daeho-ro
Copy link
Member

daeho-ro commented May 4, 2025

If this is crucial, then the changes go to upstream and apply the original file. But you did it from homebrew and so I ask a question 😅

@dblsaiko
Copy link
Contributor Author

dblsaiko commented May 4, 2025

Upstream now already requires corouties and fails the build otherwise instead of not compiling the classes, it's just not in a release yet: capnproto/capnproto@3cbd744

@chenrui333
Copy link
Member

Upstream now already requires corouties and fails the build otherwise instead of not compiling the classes, it's just not in a release yet: capnproto/capnproto@3cbd744

then maybe add a code comment to remove it in the next release? otherwise should be good to go.

@dblsaiko dblsaiko force-pushed the push-tzvzosroylvl branch from 76fd4ea to 5d5929c Compare May 4, 2025 15:36
@chenrui333 chenrui333 force-pushed the push-tzvzosroylvl branch from 5d5929c to 6fc1d46 Compare May 4, 2025 15:40
@dblsaiko dblsaiko force-pushed the push-tzvzosroylvl branch from 6fc1d46 to 900ab8e Compare May 4, 2025 16:44
capnp silently doesn't compile parts of the code when compiled with
the default standard level.
@dblsaiko dblsaiko force-pushed the push-tzvzosroylvl branch from 900ab8e to a20397e Compare May 4, 2025 16:45
@daeho-ro daeho-ro removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

:shipit: @daeho-ro has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 5, 2025 11:29
@BrewTestBot BrewTestBot added this pull request to the merge queue May 5, 2025
Merged via the queue into Homebrew:master with commit 015a4d5 May 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants