headers: rename CPU_ARCH_ABI32 to CPU_ARCH_ABI64_32 #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR renames the constant CPU_ARCH_ABI32 to CPU_ARCH_ABI64_32 to better reflect its purpose of representing 64-bit CPU architectures running with 32-bit types. The change aligns with Apple's naming conventions and improves code clarity.
Changes:
- Renamed constant from
CPU_ARCH_ABI32toCPU_ARCH_ABI64_32 - Updated comments to clarify that this mask is for "64-bit CPU architectures with 32-bit types" rather than the ambiguous "64-bit architectures running a 32-bit ABI"
- Updated the usage of the constant in
CPU_TYPE_ARM64_32definition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
woodruffw
approved these changes
Feb 1, 2026
Bo98
force-pushed
the
CPU_ARCH_ABI64_32
branch
from
5e3ee9c to
1bb7c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better matches what it actually represents. It also matches what Apple calls it.
Not a breaking change as it's private API.