ci: add promtail config validation (#193)#504
Merged
Conversation
Adds a CI step that runs `promtail -check-syntax` against configs/promtail.yml using the same image version pinned in docker-compose.yml. Mirrors the validation as a `just validate-promtail` recipe and chains it into the existing `just validate` target so local runs catch syntax regressions before push. Closes #193 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mvillmow
force-pushed
the
193-promtail-config-validation
branch
from
c40c80d to
54bdcba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatejob that runspromtail -check-syntaxagainstconfigs/promtail.ymlusinggrafana/promtail:3.1.2(the version pinned indocker-compose.yml).just validate-promtailrecipe and chains it intojust validateso local runs catch syntax regressions before push.Test plan
docker run --rm -v "$PWD/configs/promtail.yml:/etc/promtail/promtail.yml:ro" grafana/promtail:3.1.2 -config.file=/etc/promtail/promtail.yml -config.expand-env=true -check-syntax-> "Valid config file! No syntax issues found"pre-commit run --files .github/workflows/ci.yml justfilepasses (yamllint, no-silent-failure guard, continue-on-error guard)Generated with Claude Code