feat: add Logger::init() call to monitoring server startup paths#453
Merged
Conversation
✅ Dependency Audit
See the Security tab for detailed findings. Workflow: Dependency Audit |
Security Scan Results
Recommendations
Workflow: Security Scanning |
Initialize the logger explicitly in both HealthCheckServer::start() and PrometheusExporter::start() methods to ensure spdlog is ready before the first log message is emitted. This follows best practices and removes reliance on the lazy initialization guard in Logger::log(). Closes #336 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initializes the logger explicitly in both
HealthCheckServer::start()andPrometheusExporter::start()methods to ensure spdlog is ready before the first log message is emitted.This implements explicit startup initialization rather than relying on the lazy initialization guard in
Logger::log(), providing a clearer and more explicit initialization contract.Changes
Logger::init()call toHealthCheckServer::start()immediately after the running flag checkLogger::init()call toPrometheusExporter::start()immediately after the running flag checkTesting
Closes #336