Skip to content

test: add timeout markers to graceful-shutdown slow tests#484

Merged
mvillmow merged 2 commits into
mainfrom
480-auto-impl
Apr 26, 2026
Merged

test: add timeout markers to graceful-shutdown slow tests#484
mvillmow merged 2 commits into
mainfrom
480-auto-impl

Conversation

@mvillmow
Copy link
Copy Markdown
Collaborator

@mvillmow mvillmow commented Apr 26, 2026

Add pytest-timeout markers to the 3 graceful-shutdown tests that use SlowTaskClaimer(delay=10.0) to prevent CI hangs.

Closes #480

Changes

  • Added @pytest.mark.timeout(30) to test_drain_timeout_returns_false()
  • Added @pytest.mark.timeout(30) to test_drain_timeout_logs_warning()
  • Added @pytest.mark.timeout(30) to test_stop_called_even_when_drain_times_out()
  • Registered timeout marker in pyproject.toml to suppress pytest warnings

Testing

All tests pass locally without hanging:

  • test_drain_timeout_returns_false: PASSED
  • test_drain_timeout_logs_warning: PASSED
  • test_stop_called_even_when_drain_times_out: PASSED

Generated with Claude Code

@mvillmow mvillmow changed the title chore: reconcile justfile deps recipe with pixi.toml dependency workflow test: add timeout markers to graceful-shutdown slow tests Apr 26, 2026
@mvillmow mvillmow enabled auto-merge (squash) April 26, 2026 19:24
mvillmow and others added 2 commits April 26, 2026 15:00
Add Conan as a pixi.toml dependency and create a conan-install task that matches
the justfile's dependency installation approach. This reconciles the split between
the justfile (Conan) and pixi (native CMake) workflows, providing a clear path for
developers using pixi to install C++ dependencies.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add @pytest.mark.timeout(30) to the 3 tests using SlowTaskClaimer(delay=10.0)
to prevent CI hangs. Register timeout marker in pyproject.toml to suppress
pytest warnings. Fixes issue #480.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mvillmow mvillmow merged commit 86573b1 into main Apr 26, 2026
15 checks passed
@mvillmow mvillmow deleted the 480-auto-impl branch April 26, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: graceful-shutdown tests with delay=10.0 may cause CI timeout

1 participant