Conversation
CRITICAL POLICY CHANGE: All agents must create feature branches before committing code ## Changes 1. **CLAUDE.md** - Added comprehensive Git Workflow section -⚠️ MANDATORY: Branch-First Development policy - Never commit directly to main - Always use Pull Request workflow - Branch naming conventions with timestamps - Pre-commit checklist (tests, formatting, etc.) 2. **.claude/agents/chief-architect.md** - Added Git Workflow section - Workflow specific to Level 0 architectural decisions - Includes architecture decision documentation in PRs - Phase-based branch naming - Added Bash tool for git commands 3. **.claude/agents/implementation-engineer.md** - Added Git Workflow section - Standard implementation workflow - Test-passing requirements before commit - Code formatting verification - Added Bash tool for git commands ## Rationale This prevents agents from committing directly to main, which: - Enables proper code review process - Allows CI/CD to run before merge - Maintains main branch stability - Provides audit trail via Pull Requests - Prevents accidental breaking changes ## Impact All code-writing agents will now: 1. Create timestamped feature branches first 2. Commit to feature branch 3. Create PR for review 4. Wait for approval before merge ## Testing No code changes - documentation only. Verified markdown formatting. 🤖 Implemented per user requirement to enforce PR-based workflow
Extended mandatory branch-first workflow to: - Implementation engineers (senior, junior) - Test engineers (engineer, junior, specialist) - Documentation engineers (engineer, junior, specialist) - Security specialist - Performance engineer Each agent now has: - Bash tool added to frontmatter (where missing) - Comprehensive Git Workflow section with: - Feature branch creation requirement - Branch naming conventions - Commit and push procedures - PR creation templates - Pre-commit verification checklists - What NOT to do warnings All agents enforce: - Never commit to main directly - Always create feature branch first - Wait for review before merge - Validate work before committing This ensures consistent development workflow across all code-writing and specialist agents. 🤖 Generated with Claude Code
Extended mandatory branch-first workflow to ALL remaining agents: **Specialists (2):** - implementation-specialist.md (feat/ branches) - performance-specialist.md (perf/ branches) **Design Agents (3):** - architecture-design.md (arch/ branches) - security-design.md (security/ branches) - integration-design.md (integration/ branches) **Orchestrators (7):** - foundation-orchestrator.md - shared-library-orchestrator.md - agentic-workflows-orchestrator.md - papers-orchestrator.md - tooling-orchestrator.md - cicd-orchestrator.md - code-review-orchestrator.md **Review Specialists (14):** - architecture-review-specialist.md - implementation-review-specialist.md - security-review-specialist.md - performance-review-specialist.md - safety-review-specialist.md - algorithm-review-specialist.md - mojo-language-review-specialist.md - test-review-specialist.md - documentation-review-specialist.md - dependency-review-specialist.md - data-engineering-review-specialist.md - research-review-specialist.md - paper-review-specialist.md - blog-writer-specialist.md Each agent now has: ✅ Bash tool added to frontmatter ✅ Comprehensive Git Workflow section with: - Feature branch creation requirement - Role-specific branch naming - Commit and push procedures - PR creation guidelines - What NOT to do warnings **Design agents**: arch/, security/, integration/ branches **Orchestrators**: feat/ branches with coordination emphasis **Reviewers**: fix/review- branches, coordinate via Task tool This completes the Git workflow rollout to ALL 39 agent configuration files in ProjectKeystone. Combined with PR #60 (3 agents) and PR #61 (10 agents): - TOTAL: 39/39 agents now enforce branch-first workflow - 100% coverage across all code-writing agents - Consistent workflow across entire agent hierarchy 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the mandatory branch-first Git workflow rollout by extending it to ALL remaining 36 agent configuration files.
🎯 Complete Coverage
Combined with PR #60 (3 agents), this PR brings the total to 39/39 agents with Git workflow policy.
Agents Updated in This PR (36 Total)
Implementation Engineers (2)
✅
implementation-specialist.md- Component breakdown specialist✅
performance-specialist.md- Performance coordination specialistDesign Agents (3)
✅
architecture-design.md- Module architecture design✅
security-design.md- Security threat modeling✅
integration-design.md- API and integration designOrchestrators (7)
✅
foundation-orchestrator.md- Foundation setup coordination✅
shared-library-orchestrator.md- Shared library coordination✅
agentic-workflows-orchestrator.md- Workflow automation✅
papers-orchestrator.md- Research paper implementation✅
tooling-orchestrator.md- Tool development coordination✅
cicd-orchestrator.md- CI/CD pipeline coordination✅
code-review-orchestrator.md- Code review routingReview Specialists (14)
✅
architecture-review-specialist.md- Architecture review✅
implementation-review-specialist.md- Code quality review✅
security-review-specialist.md- Security vulnerability review✅
performance-review-specialist.md- Performance analysis✅
safety-review-specialist.md- Memory/type safety review✅
algorithm-review-specialist.md- Algorithm correctness✅
mojo-language-review-specialist.md- Mojo idiom review✅
test-review-specialist.md- Test quality review✅
documentation-review-specialist.md- Documentation review✅
dependency-review-specialist.md- Dependency management✅
data-engineering-review-specialist.md- Data pipeline review✅
research-review-specialist.md- Research methodology✅
paper-review-specialist.md- Academic paper quality✅
blog-writer-specialist.md- Development blog writingFrom PR #61 Initial Commit (10)
✅
senior-implementation-engineer.md✅
junior-implementation-engineer.md✅
test-engineer.md✅
junior-test-engineer.md✅
test-specialist.md✅
documentation-engineer.md✅
junior-documentation-engineer.md✅
documentation-specialist.md✅
security-specialist.md✅
performance-engineer.mdChanges for Each Agent
All 36 agents now include:
1. Added
BashToolBashtool2. Role-Specific Git Workflow Sections
Specialists & Engineers:
Design Agents:
arch/,security/,integration/Orchestrators:
feat/section-name-TIMESTAMPReviewers:
3. Consistent Prohibitions
All agents enforce:
maingit push origin mainComplete Project Coverage
Total Agents with Git Workflow: 39/39 (100%)
From PR #60 (MERGED):
From This PR:
4-39. All remaining 36 agents
Branch Naming by Agent Type
feat/,fix/,refactor/feat/new-feature-20251126-183834perf/,fix/perf-perf/optimize-scheduler-20251126-183834arch/arch/messaging-design-20251126-183834security/,fix/security-security/auth-hardening-20251126-183834integration/integration/api-design-20251126-183834docs/,fix/docs-docs/api-reference-20251126-183834test/,fix/test-test/unit-tests-20251126-183834feat/feat/foundation-setup-20251126-183834fix/review-fix/review-findings-20251126-183834Testing
Documentation Changes Only
Batch Processing
Used efficient bash scripts to:
Bashtool to frontmatterImpact
Before this PR:
After this PR:
All agents across the entire hierarchy now:
Verification
Check git workflow sections added:
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com