Open
Conversation
paolocappelletti
approved these changes
Nov 18, 2024
| # Branch notes | ||
|
|
||
| Based on the branch 'stable2407' from https://github.com/polkadot-evm/frontier/ where we first replaced all reference to the polkadot | ||
| git branch in `Cargo.toml` with a fake version `9.9.9` and the use `update-polkadot-sdk-deps.py` script from |
saratnt
approved these changes
Nov 20, 2024
| # Branch notes | ||
|
|
||
| Based on the branch 'stable2407' from https://github.com/polkadot-evm/frontier/ where we first replaced all reference to the polkadot | ||
| git branch in `Cargo.toml` with a fake version `9.9.9` and the use `update-polkadot-sdk-deps.py` script from |
| ## ATTENTION | ||
|
|
||
| `substrate-test-runtime-client` is not published, so leave the definition pointing to a git source. | ||
| Why this is wrong: because the `substrate-test-runtime-client` use lot of substrate dependency |
There was a problem hiding this comment.
typo:
use lot of substrate dependency -> uses lot of substrate dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.