This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Update storybook docs for breadcrumbs, calendar and callout#637
Merged
matteovivona merged 7 commits intoHospitalRun:masterfrom Nov 8, 2020
Merged
Update storybook docs for breadcrumbs, calendar and callout#637matteovivona merged 7 commits intoHospitalRun:masterfrom
matteovivona merged 7 commits intoHospitalRun:masterfrom
Conversation
RobertoMSousa
changed the title
jackcmeyer
suggested changes
Oct 29, 2020
blestab
approved these changes
Nov 1, 2020
There was a problem hiding this comment.
LGTM if you can just address the changes suggested by @jackcmeyer
blestab
suggested changes
Nov 1, 2020
There was a problem hiding this comment.
LGTM if you can just address the changes suggested by @jackcmeyer
Contributor
Author
|
@blestab , typo fixed. |
|
Thanks @RobertoMSousa |
Contributor
Author
That was already removed on this commit |
matteovivona
approved these changes
Nov 8, 2020
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes callout, breadcrumbs and calendar stories.
Changes proposed in this pull request:
Update the docs of the components mentioned previously to allow the storybook 6 to render the docs page and fix a bug on the calendar that was preventing the component to be rendered at all on storybook.