Remove redundant class in 3-class.js example
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'use strict'; | ||
|
|
||
| const logable = (fields) => | ||
| class Logable { |
Member
There was a problem hiding this comment.
This shows class-returning function, rewriting will hide the essence of the example
| }, | ||
| }); | ||
| const logable = fieldRules => data => { | ||
| var result = {} |
Member
There was a problem hiding this comment.
Why var?
Suggested change
| var result = {} | |
| const result = {}; |
Comment on lines
-40
to
+34
| const p1 = new Person({ name: 'Marcus Aurelius', born: 121 }); | ||
| const p1 = Person({ name: 'Marcus Aurelius', born: 121 }); |
Member
There was a problem hiding this comment.
We use UpperCamel for classes and lowerCamep for functions, methods
| }); | ||
| const logable = fieldRules => data => { | ||
| var result = {} | ||
| Object.keys(fieldRules).forEach(key => { |
Member
There was a problem hiding this comment.
keys/forEach will create array and make more function calls
| }) | ||
| result.toString = () => | ||
| `Logable\t${ | ||
| Object.keys(fieldRules).map(key => data[key] + '\t').join() |
Member
There was a problem hiding this comment.
It is not ok to access data[key] from map, because data is out of mapping function scope, it will work but semantics does not fit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.