Fix ExecutableMatcher to enforce invocation constraints for constructors

[Copilot]

ExecutableMatcher applies to both methods and constructors, but setInvokedMethods() and setInvokedConstructors() constraints were only enforced when matching methods. Constructor matches silently ignored these constraints.

Root Cause

Three related issues:

• Data structures keyed by Method: Maps used Method as keys instead of Executable, preventing constructor data storage
• DEX analysis skipped constructors: Analysis always called getDeclaredMethod(), failing to resolve <init> methods as Constructor objects
• Constraint checks gated on instanceof Method: doMatch() only checked constraints when reflect instanceof Method

Changes

• Changed methodInvocationsMap and constructorInvocationsMap to key by Executable
• Updated DEX analysis to detect <init> and call getDeclaredConstructor() appropriately
• Removed instanceof Method guard from constraint checks in doMatch()
• Updated getInvokedMethods() and getInvokedConstructors() to handle both executable types
• Extracted asExecutable() helper to eliminate type-casting duplication

Example

Before: constraints silently ignored for constructors

// This would match ANY constructor, ignoring the constraint
builder.constructor()
    .setInvokedMethods(builder.exactMethod("...").observe())

After: constraints properly enforced for both

// Now correctly filters constructors that invoke the specified method
builder.constructor()
    .setInvokedMethods(builder.exactMethod("...").observe())

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR fixes ExecutableMatcher so that invocation constraints (setInvokedMethods() / setInvokedConstructors()) are enforced consistently for both methods and constructors, by ensuring DEX invocation relationships can be stored and queried for either executable type.

Changes:

• Switched invocation relationship maps to be keyed by Executable instead of Method.
• Updated DEX analysis reflection resolution to treat "<init>" as a constructor (getDeclaredConstructor()).
• Removed method-only gating so invocation constraints are evaluated for constructors as well.

Comments suppressed due to low confidence (2)

helper/src/main/java/io/github/libxposed/helper/HookBuilderImpl.java:667

• The invocation-collection block after resolving currentExecutable is indented as if it were still inside the inner try/catch, which makes the control flow hard to follow. Consider reformatting / adjusting indentation (and possibly extracting the resolution + collection into small helpers) so the outer vs inner try scopes are visually clear.

                                        // Try to resolve current method or constructor via reflection
                                        Executable currentExecutable;
                                        try {
                                            var currentClass = reflector.loadClass(currentClassName);
                                            var currentParamTypes = getParameterTypesFromProto(currentProto);
                                            if (currentParamTypes == null) {
                                                return;
                                            }
                                            // Check if it's a constructor
                                            if ("<init>".equals(currentMethodName)) {
                                                currentExecutable = currentClass.getDeclaredConstructor(currentParamTypes);
                                            } else {
                                                currentExecutable = currentClass.getDeclaredMethod(currentMethodName, currentParamTypes);
                                            }
                                        } catch (ClassNotFoundException | NoSuchMethodException e) {
                                            return;
                                        }

                                            // Collect all methods and constructors invoked by this method
                                            Set<Method> invokedMethodsSet = new HashSet<>();
                                            Set<Constructor<?>> invokedConstructorsSet = new HashSet<>();

helper/src/main/java/io/github/libxposed/helper/HookBuilderImpl.java:1748

• Potentially confusing name: method doMatch also refers to field parameterCount (as this.parameterCount).

            final int parameterCount;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

currentExecutable is nullable and is later used as the key for ConcurrentHashMap.get(...), which will throw if it ever becomes null (CHM disallows null keys). Since this method already proves reflect is a Method or Constructor, consider assigning Executable currentExecutable = (Executable) reflect; (or make asExecutable() non-null / assert) to remove the nullable path and avoid future refactors accidentally introducing an NPE.