-
Notifications
You must be signed in to change notification settings - Fork 727
Fix unused functions on Android #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
basilgello
commented
Sep 29, 2024
- Implement USE_OS_TZDB for Android
- Ensure Android private functions dont show up
- Fix unused functions on Android
... for external consumers like tests Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
56cc64e to
5b0a340
Compare
|
@HowardHinnant Now no more unused functions in Android! Apart from that, tests against NDK r27b caught the following static assertion failures: Kodi compiles and passes integration tests just fine, buut you might still find the issue interesting! |
|
Reproducer: |
|
You download https://dl.google.com/android/repository/android-ndk-r27b-darwin.dmg and unpack stuff so |
src/tz.cpp
Outdated
|
|
||
| static | ||
| #if !defined(ANDROID) && !defined(__ANDROID__) | ||
| Wstatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date/src/tz.cpp:656:1: error: unknown type name 'Wstatic'; did you mean 'static'?
656 | Wstatic
| ^~~~~~~
| static
1 error generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo-ed :( Fixed!
... spotted with `-Wall` Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
5b0a340 to
77d0f31
Compare
|
Merged (with a couple of trivial fixes): 447f5a3 |