Conversation
iupfal
reviewed
Jul 21, 2025
Contributor
iupfal
left a comment
iupfal
left a comment
There was a problem hiding this comment.
Overall, the tests and changes make sense to me. I added one comment to the momentum tests as the test reveals one unintended behavior which we should fix.
kirbyh
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You're making a pull request to a branch (probably main) of MITWindFarm. Please ensure you have done the following.
If you want more details on best practices, please see the following guide on the Howland Lab Google Drive.
Happy merging!
The only changes here are to add tests and make sure that MIT Rotor is compatible with the changes to the UMM. This does not add tilt to MITRotor yet.