Conversation
Contributor
Author
|
It is working now! Turns out that it was just a setup problem, not actually a problem with the code. See the new images from MITWindfarm here: Howland-Lab/MITWindfarm#32 |
iupfal
requested changes
Oct 28, 2025
Contributor
iupfal
left a comment
iupfal
left a comment
There was a problem hiding this comment.
Nice work! Only one comment on the azimuthal coordinates in the aerodynamic model which needs to be addressed.
| Vtan = ( | ||
| (1 + aprime) * tsr * geom.mu_mesh | ||
| - U * (1 - an) | ||
| * np.cos(geom.theta_mesh) |
Contributor
There was a problem hiding this comment.
I think you might be missing an offset here on theta_mesh. If you rotate the rotor so that tilt+yaw = effective yaw then don't you need to correct the azimuthal position, theta_mesh, as well?
Contributor
Author
|
I think this has been addressed now! |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You're making a pull request to a branch (probably main) of MITWindFarm. Please ensure you have done the following.
If you want more details on best practices, please see the following guide on the Howland Lab Google Drive.
Happy merging!
I am not 100% done here - for some reason, when I try to optimize for tilt from angles of (0 to 15 degrees) I get a different answer than with yaw. So I am trying to determine where that is coming from - but that could be anywhere from UMM to here to MITWindfarm. So I might as well open this.