-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/responsive design #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Howllo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howllo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design is still not strict. The feed should be only max and min of 650px. There should not be uneven padding at the top. They should be both be hard locked to around 20px-ish paddingTop. Responsive design doesn't mean stretchy design. Stretchy design usually breaks the UI styling like what it is doing currently. It you should be changing component out and replacing them with more mobile friendly ones based on break points.
Howllo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way better than first time, but I gave you wrong information. The size of the feed is actually 600px. After reworking the post and post page I realized that it was actually 650.
It looks great, but few errors there are border radius on this post making it not line up. It needs to be zero radius. It also need line up the lines to be line like rest of the lines:

The post icon should be on rightsidebar and on two end, justify end and align end. I think if that doesn't work you can also try marginTop auto.

This will make the overall design much better.

Since you already adjusting the navbar stuff. It would be nice also extend the nav buttons full length like this:

This would give it finishing touch. Overall, great execution so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with the Participate in discussion that is now too large;
vs
Also seems like the user profile is also missing lines:

vs
Optional (This might break the core of the website, so you don't have to do this):
In the current design the scroll bar is inside one of the grids (Middle grid that allows for y overflow):

The original design is suppose to have the scroll bar on the far left side, where you can scroll the everyone menu, but I think this is a core website that could break a lot of things. Once the other fixes are out you can try fix this, but you don't have to at all. It just design flaw in my original design. Reason I am stating this that it could take 30 minutes to fix or entire day.
Howllo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.










Improved overall responsiveness, cleaned up jsx files and made external css sheets.