Changed to use static regex rather than rely on the regex cache#119
Merged
jbogard merged 1 commit intoHtmlTags:masterfrom Dec 28, 2020
Merged
Conversation
…e are used all the time, so eliminating the cache can be a big performance win for our code. Originally we moved all our regular expressions to be compiled, but during performance tuning found those to have significant thread locking issues causing performance degradation on our web site, so we removed that. I don't believe that has been improved recently.
Contributor
Author
|
Thank you Jimmy! |
kendallb
added a commit
to kendallb/htmltags
that referenced
this pull request
Oct 30, 2022
…performance Changed to use static regex rather than rely on the regex cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to use static regex rather than rely on the regex cache as these are used all the time, so eliminating the cache can be a big performance win for our code. Originally we moved all our regular expressions to be compiled, but during performance tuning found those to have significant thread locking issues causing performance degradation on our web site, so we removed that. I don't believe that has been improved recently.
Sorry it took me 6 years to get back around to this, but we have been using our own custom build of HtmlTags all these years, and we are trying to move to ASP.Net Core, so had to port this to .Net Standard so want to get back to using the official version again.