Fix a bug where cookies with Max-Age too big are not stored#1094
Merged
rbri merged 1 commit intoHtmlUnit:masterfrom Mar 12, 2026
Merged
Fix a bug where cookies with Max-Age too big are not stored#1094rbri merged 1 commit intoHtmlUnit:masterfrom
rbri merged 1 commit intoHtmlUnit:masterfrom
Conversation
|
Member
|
@duonglaiquang will work on that later today, maybe i can add a unit test. @duonglaiquang do you need a release for all that? As i'm working towards 5.0, no 4.x releases are planned and the 5.0 might need some more time. and last - have you seen my email? |
Contributor
Author
|
@rbri Thank you very much. |
Member
|
hope the java17 move is ok for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR does the following
Fix
HtmlUnitMaxAgeHandlerto correctly handle cookies with large, negative, or non-numericmax-agevalues per RFC 6265.Problem
When a server sends a cookie with a
max-agevalue that exceedsInteger.MAX_VALUE(e.gmax-age=99999999999),Integer.parseIntthrowsNumberFormatException, which is wrapped intoMalformedCookieException, causing the entire cookie to be rejected.Per RFC 6265, large values should be capped to a limit (400 days) rather than rejected.
Additionally, negative/zero delta-seconds should set expiry to the earliest representable date instead of offsetting current time.