Add comparison option to GetParametersValue(s)#107
Conversation
|
This indeed looks like a useful improvement but, if you don't mind, please raise an issue to describe the improvement you are submitting, why you thing its helpful, etc. The issue is particularly important because I reference them in the release notes) to let developers know what new in each released version. Thanks |
|
oh and kudos for including unit test to prove that your improvement works as intended! |
Jericho
left a comment
There was a problem hiding this comment.
Looks good to me!
Thank you for your contribution.
|
I have raised an issue to cover this. You should note that while this change is non-breaking when compiling code it is breaking if consumers just drop in a new DLL without recompiling as the additional optional argument will cause the symbol table to change. If you want to ensure this is non-breaking in all circumstances we can use method overloads without default value so that the original method signatures would also remain in the symbol table. //Original signatures
GetParameterValue(string)
GetParameterValues(string)
//Additional new signatures
GetParameterValue(string, StringComparison)
GetParameterValues(string, StringComparison) |
I found having a case insensitive option to be useful where API contracts were poorly defined.