Skip to content

Add comparison option to GetParametersValue(s)#107

Merged
Jericho merged 1 commit intodevelopfrom
unknown repository
May 30, 2022
Merged

Add comparison option to GetParametersValue(s)#107
Jericho merged 1 commit intodevelopfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 26, 2022

I found having a case insensitive option to be useful where API contracts were poorly defined.

@Jericho
Copy link
Copy Markdown
Collaborator

Jericho commented May 29, 2022

This indeed looks like a useful improvement but, if you don't mind, please raise an issue to describe the improvement you are submitting, why you thing its helpful, etc.

The issue is particularly important because I reference them in the release notes) to let developers know what new in each released version.

Thanks

@Jericho
Copy link
Copy Markdown
Collaborator

Jericho commented May 29, 2022

oh and kudos for including unit test to prove that your improvement works as intended!

Copy link
Copy Markdown
Collaborator

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thank you for your contribution.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 30, 2022

I have raised an issue to cover this.

You should note that while this change is non-breaking when compiling code it is breaking if consumers just drop in a new DLL without recompiling as the additional optional argument will cause the symbol table to change. If you want to ensure this is non-breaking in all circumstances we can use method overloads without default value so that the original method signatures would also remain in the symbol table.

//Original signatures
GetParameterValue(string) 
GetParameterValues(string) 

//Additional new signatures
GetParameterValue(string, StringComparison) 
GetParameterValues(string, StringComparison) 

@Jericho Jericho linked an issue May 30, 2022 that may be closed by this pull request
@Jericho Jericho merged commit bab5397 into Http-Multipart-Data-Parser:develop May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comparison option to GetParametersValue(s)

1 participant