Use mimetypes for the detection of files in form-data#89
Merged
Jericho merged 9 commits intoHttp-Multipart-Data-Parser:developfrom Dec 1, 2020
bkrbtc:develop
Merged
Use mimetypes for the detection of files in form-data#89Jericho merged 9 commits intoHttp-Multipart-Data-Parser:developfrom bkrbtc:develop
Jericho merged 9 commits intoHttp-Multipart-Data-Parser:developfrom
bkrbtc:develop
Conversation
Collaborator
|
Thank you for submitting this PR. Do you mind raising an issue to discuss the underlying problem you are trying to solve? Please include as much info as you can such as repro steps, describe the circumstances where you experience this problem etc. |
Contributor
Author
|
#90 |
and also SA1128 Put constructor initializers on their own line
…ch parameter should be placed on its own line.
Jericho
requested changes
Nov 30, 2020
Collaborator
There was a problem hiding this comment.
Also I get a few warnings in Visual Studio such as:
- SA1001 Commas should be followed by whitespace.
- SA1013 Closing brace should be preceded by a space.
- SA1629 Documentation text should end with a period
I'll see if can push changes to your PR to fix those.
Co-authored-by: Jericho <desautelsj@hotmail.com>
Contributor
Author
For me too. If you like to merge feel free. Thank you for your support. |
Collaborator
|
I got busy with other projects in the last few days but I have some time now. Will look at releasing today or tomorrow. |
Contributor
Author
|
No Problem. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 7578 defines the "filename" parameter as "SHOULD". This means the existence of the parameter is not a sufficient criteria to distinguish between files and parameters. I added an option to detectet files by it's mimetype. This list can be enhanced by the user of the library