Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this rewrite is to simplify the controller for easier maintenance and significantly reduce the number of locks required. Additionally, it aims to increase the tick speed since I plan to move tasks such as starting units and calculating how many need to be started into the main tick loop. If the tick speed is too low, the controller's response times may be delayed—1 TPS results in an average response time of 1000ms, while 20 TPS would reduce that to 50ms. This adjustment should improve long-term maintainability. The drivers are always invoked in a new thread using tokio::spawn to ensure they don’t block the main tick loop.