-
Notifications
You must be signed in to change notification settings - Fork 9
Added triton interop support #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added triton interop support #36
Conversation
Balint-R
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. I have not really looked at test_triton.py or examples/triton_interop.py yet. I will review this again after most of my comments are resolved.
My biggest question right now is probably, what is the code that parses how many arguments the Triton function has based on the MLIR and why do we need it? Also in general, how does the process of actually calling the Triton function work?
|
We should also figure out how to set up Triton in CI. |
Yes I have been talking with @xushengj about this. It will probably be something I do at the same time when I am working on the feature to separate the formatting and the test on CI. |
80271ea to
99e5705
Compare
e62f6a0 to
f871864
Compare
3d10202 to
bb1009e
Compare
ac9f27a to
799fcba
Compare
|
Comments I marked as resolved but we should revisit later:
|
|
Maybe address my existing comments and #63, and then we can merge. I am tired of reading over this so many times. There are probably not major issues anymore. |
3f72050 to
6c35498
Compare
6c35498 to
17f5563
Compare
Balint-R
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesthejellyfish you should fix the one thing I commented today, rebase onto main (you will have to resolve a trivial merge conflict), then you can merge!
17f5563 to
3212027
Compare
added the ability to call triton functions from within a PyDSL function. This works by parsing the triton ir (ttir), and then using an open-source tool called triton-adapter-opt from triton-ascend to convert the ttir to linalg mlir, which then gets combined into the PyDSL mlir file. Note that when calling a triton function, in addition to the triton args, you must include three extra UInt32 parameters which define the grid index (x,y,z)