fix: disable UNLISTEN for GaussDB and unskip related tests #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where releasing a connection back to the pool would trigger an `UNLISTEN *` command. This caused failures in GaussDB environments (specifically in Oracle compatibility mode) where the PostgreSQL `LISTEN/NOTIFY` mechanism is not supported. Changes: 1. Modified `_detect_server_capabilities` to identify GaussDB environments by checking for `sql_mode` in connection settings. 2. Explicitly set `notifications = False` for these environments. This prevents the connection pool from attempting to execute `UNLISTEN *` during the cleanup/release phase. 3. Ensured that standard PostgreSQL connections retain full `LISTEN/UNLISTEN` functionality. 4. Re-enabled (unskipped) unit tests that were previously failing or skipped due to this incompatibility.
The previous detection logic was insufficient for standard OpenGauss environments (e.g., A-compatibility or default modes) as it relied on keys like 'sql_mode' which may not exist. Changes: 1. Updated `_detect_server_capabilities` to identify GaussDB/OpenGauss using the core parameter `session_respool`.
The previous detection logic was insufficient for standard OpenGauss environments (e.g., A-compatibility or default modes) as it relied on keys like 'sql_mode' which may not exist. Changes: 1. Updated `_detect_server_capabilities` to identify GaussDB/OpenGauss using the core parameter `session_respool`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where releasing a connection back to the pool would trigger an
UNLISTEN *command. This caused failures in GaussDB environments (specifically in Oracle compatibility mode) where the PostgreSQLLISTEN/NOTIFYmechanism is not supported.Changes:
_detect_server_capabilitiesto identify GaussDB environments by checking forsql_modein connection settings.notifications = Falsefor these environments. This prevents the connection pool from attempting to executeUNLISTEN *during the cleanup/release phase.LISTEN/UNLISTENfunctionality.