Fix Faker string type assertion to properly handle empty string and None #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The internal type matcher in Faker previously treated
Noneas invalid when the expected string value (want) was an empty string ("") orNone. This led to false assertion failures for nullable or optional string fields, which is a common pattern in JSON Schema/OpenAPI schemas.This change makes the
strbranch consistent with the existingbyteshandling: when the expected value is""orNone, both""andNoneare accepted as valid matches.Changes Made
tests/fix_faker.pyspec == strbranch inmatch_anyto acceptgot == ""orgot is Nonewheneverwant == ""orwant is NoneTesting
bytes,bytearray, ormemoryviewhandlingwant="",want=None, and non-empty strings