Make the history purger query more efficient#1319
Merged
Conversation
tpetr
reviewed
Oct 17, 2016
| abstract Date getMinUpdatedAtWithLimitForRequest(@Bind("requestId") String requestId, @Bind("limit") Integer limit); | ||
|
|
||
| @SqlUpdate("UPDATE taskHistory SET bytes = '' WHERE requestId = :requestId AND updatedAt \\< :updatedAtBefore") | ||
| @SqlUpdate("UPDATE taskHistory SET bytes = '', purged = true WHERE requestId = :requestId AND purged = false AND updatedAt \\< :updatedAtBefore") |
Contributor
There was a problem hiding this comment.
is true proper SQL here? wouldn't it be 1? (not 100% sure myself)
Contributor
Author
|
Removed the update statement from the migration. When the purger first runs, the relevant rows will be updated and all subsequent runs of the purger will be faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the purger query can grow in an unbounded manner when in the mode to set bytes to
''rather than deleting, since the query just goes byupdatedAt < x. This PR updates thetaskHistorytable to have an additional indexedpurgedcolumn. This way we can limit our query to only tasks we have not already purged./cc @tpetr @darcatron