Revert breaking change in enum deserialization#1541
Closed
PtrTeixeira wants to merge 1 commit into
Closed
Conversation
There appears to have been a change right around Dropwizard 1.0 in how enums are deserialized; my guess is that somehow `@JsonCreator` cascades and prevents the `FuzzyEnumModule` from being applied properly, but I'm not really sure. The result was that `SingularityContainerType` wasn't accepting lowercase `mesos`, `docker` as valid values, which was a breaking change from before - and in particular, prevented creating deploys from the UI.
Contributor
|
@PtrTeixeira I can't seem to reproduce this one. I tried the same fields via ui in our staging setup and a lower case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to have been a change right around Dropwizard 1.0
in how enums are deserialized; my guess is that somehow
@JsonCreatorcascades and prevents the
FuzzyEnumModulefrom being applied properly,but I'm not really sure. The result was that
SingularityContainerTypewasn't accepting lowercase
mesos,dockeras valid values, which wasa breaking change from before - and in particular, prevented creating
deploys from the UI.
See also dropwizard/dropwizard#1985, which is kind-of related, I think
/cc @ssalinas