Skip to content

Nix the old dashboard and default to requests page #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssalinas merged 2 commits into from
Aug 16, 2018
Merged

Nix the old dashboard and default to requests page #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
697db40
Nix the old dashboard and default to requests page
ssalinas Aug 9, 2018
e22c613
move requests in the nav
ssalinas Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions SingularityUI/app/components/common/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,12 @@ const Navigation = (props) => {
</div>
<div className="collapse navbar-collapse" id="navbar-collapse">
<ul className="nav navbar-nav">
<li className={classnames({active: isActive('/', fragment)})}>
Copy link
Copy Markdown

@andyhuang91 andyhuang91 Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Requests is the default tab now, we should reorder the nav items so that Status isn't first.

Copy link
Copy Markdown
Contributor Author

@ssalinas ssalinas Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can do that as well

<Link to="/">Dashboard {isActive('/', fragment) && <span className="sr-only">(current)</span>}</Link>
<li className={classnames({active: isActive('requests', fragment)})}>
<Link to="/requests">Requests {isActive('requests', fragment) && <span className="sr-only">(current)</span>}</Link>
</li>
<li className={classnames({active: isActive('status', fragment)})}>
<Link to="/status">Status {isActive('status', fragment) && <span className="sr-only">(current)</span>}</Link>
</li>
<li className={classnames({active: isActive('requests', fragment)})}>
<Link to="/requests">Requests {isActive('requests', fragment) && <span className="sr-only">(current)</span>}</Link>
</li>
<li className={classnames({active: isActive('tasks', fragment)})}>
<Link to="/tasks">Tasks {isActive('tasks', fragment) && <span className="sr-only">(current)</span>}</Link>
</li>
Expand Down
228 changes: 0 additions & 228 deletions SingularityUI/app/components/dashboard/DashboardPage.jsx
View file
Open in desktop

This file was deleted.

Loading