Conversation
Contributor
ssalinas
commented
Feb 24, 2015
ssalinas
commented
- Add search over all s3 logs when no tasks are found in date range
Contributor
There was a problem hiding this comment.
what does the if/else do here? only calls convert_to_days() if its a true-ish value?
Contributor
Author
There was a problem hiding this comment.
if you provide a value for args.start_days, call that to make sure it's value that can be used, if not, keep it as is. I can rewrite it to be more clear
Contributor
Author
There was a problem hiding this comment.
On second thought, we provide a default value for that, so we don't need the if to check that it isn't None
Contributor
|
LGTM thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.