Skip to content

set a default for s3UploaderKeyPattern #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tpetr merged 3 commits into from
Nov 30, 2015
Merged

set a default for s3UploaderKeyPattern #784

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb61a39
set a default for s3UploaderKeyPattern
ssalinas Nov 25, 2015
4f0d0da
mark as NotNull
ssalinas Nov 25, 2015
30bc620
s3UploaderKeyPattern should be NotEmpty, not just NotNull
Nov 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...c/main/java/com/hubspot/singularity/executor/config/SingularityExecutorConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ public class SingularityExecutorConfiguration extends BaseRunnerConfiguration {
@JsonProperty
private String serviceFinishedTailLog = "tail_of_finished_service.log";

@NotEmpty
@JsonProperty
private String s3UploaderKeyPattern;
private String s3UploaderKeyPattern = "%requestId/%Y/%m/%taskId_%index-%s-%filename";

@JsonProperty
private String s3UploaderBucket;
Expand Down