Skip to content

Move config module to local-dev-lib#22

Merged
camden11 merged 11 commits into
mainfrom
pull-in-local-dev-lib
Oct 31, 2023
Merged

Move config module to local-dev-lib#22
camden11 merged 11 commits into
mainfrom
pull-in-local-dev-lib

Conversation

@camden11
Copy link
Copy Markdown
Contributor

@camden11 camden11 commented Jul 27, 2023

Description and Context

This removes the config module from the repo in favor of pulling it in from local-dev-lib. This will allow us to start using local-dev-lib in hubspot-cli without having more than one instance of config

This PR can be tested by yarn linking cli lib in hubspot-cli, running some commands, and making sure nothing breaks

TODO

After this is released, we will need to remove deps on cli-lib/config in favor of local-dev-lib/config in hubspot-cli and hubspot-cms-vscode.

Who to Notify

@brandenrodgers

@camden11 camden11 removed the request for review from kemmerle October 26, 2023 18:22
@camden11 camden11 marked this pull request as ready for review October 26, 2023 18:22
Copy link
Copy Markdown
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it seems like it's all WAD. We may want to hold off on merging + releasing this until we get all of the other smaller changes merged and released. This PR should probably be in a major release because it's such a big change

@camden11 camden11 merged commit d5d2e0f into main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants