Move config module to local-dev-lib#22
Merged
Merged
Conversation
brandenrodgers
approved these changes
Oct 31, 2023
Contributor
brandenrodgers
left a comment
There was a problem hiding this comment.
I tested this and it seems like it's all WAD. We may want to hold off on merging + releasing this until we get all of the other smaller changes merged and released. This PR should probably be in a major release because it's such a big change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
This removes the
configmodule from the repo in favor of pulling it in fromlocal-dev-lib. This will allow us to start using local-dev-lib inhubspot-cliwithout having more than one instance ofconfigThis PR can be tested by
yarn linking cli lib inhubspot-cli, running some commands, and making sure nothing breaksTODO
After this is released, we will need to remove deps on
cli-lib/configin favor oflocal-dev-lib/configinhubspot-cliandhubspot-cms-vscode.Who to Notify
@brandenrodgers