Allow double underscore in the field name for filtering#19
Merged
boulter merged 1 commit intoHubSpot:masterfrom Feb 26, 2021
Merged
Conversation
boulter
approved these changes
Feb 26, 2021
Contributor
Author
|
Thanks @boulter. Can you please merge this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, we will need to allow field names with double underscores in it while filtering. So PR updates the newer version of the method
parseUriParamswhich allows double underscores in the field names without breaking existing usages.One case where this new logic will have issue is when we use implicit
eqfilter with a double underscore field such asfoo__bar=valueand in this case we might need to use the expliciteq(foo__bar__eq=value) to make this work, otherwise it will considerbaras filter and throw invalid filter exception.