Skip to content

Allow double underscore in the field name for filtering#19

Merged
boulter merged 1 commit intoHubSpot:masterfrom
gobimcp:allow-double-underscore-field-name
Feb 26, 2021
Merged

Allow double underscore in the field name for filtering#19
boulter merged 1 commit intoHubSpot:masterfrom
gobimcp:allow-double-underscore-field-name

Conversation

@gobimcp
Copy link
Contributor

@gobimcp gobimcp commented Feb 26, 2021

In some cases, we will need to allow field names with double underscores in it while filtering. So PR updates the newer version of the method parseUriParams which allows double underscores in the field names without breaking existing usages.

One case where this new logic will have issue is when we use implicit eq filter with a double underscore field such as foo__bar=value and in this case we might need to use the explicit eq (foo__bar__eq=value) to make this work, otherwise it will consider bar as filter and throw invalid filter exception.

@gobimcp
Copy link
Contributor Author

gobimcp commented Feb 26, 2021

Thanks @boulter. Can you please merge this as well?

@boulter boulter merged commit f81bcce into HubSpot:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants