Accept Gradle properties for Sonatype + signing credentials#4
Merged
Conversation
Why: the HubSpotEngineering/oss-release Gradle release flow exports
credentials as ORG_GRADLE_PROJECT_mavenCentralUsername/Password and
ORG_GRADLE_PROJECT_signingInMemoryKey{,Id,Password}. The current
publish/signing config only reads SONATYPE_* / GPG_SIGNING_* env vars,
so the shared release job can't authenticate to Sonatype or sign jars.
Reading via findProperty(...) with the existing env vars as a fallback
keeps the standalone publish-sonatype.yml workflow working unchanged
while letting oss-release drive a release without a wrapper.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jaredstehler
approved these changes
Apr 30, 2026
jaredstehler
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: the HubSpotEngineering/oss-release Gradle release flow exports credentials as ORG_GRADLE_PROJECT_mavenCentralUsername/Password and ORG_GRADLE_PROJECT_signingInMemoryKey{,Id,Password}. The current publish/signing config only reads SONATYPE_* / GPG_SIGNING_* env vars, so the shared release job can't authenticate to Sonatype or sign jars.
Reading via findProperty(...) with the existing env vars as a fallback keeps the standalone publish-sonatype.yml workflow working unchanged while letting oss-release drive a release without a wrapper.