Conversation
jasmith-hs
approved these changes
Mar 3, 2023
jasmith-hs
added a commit
that referenced
this pull request
Mar 16, 2026
The benchmark module was removed in PR #1018 because it was a disconnected directory that broke internal builds. This restores benchmarking as test-scoped JMH code within the existing project, so it compiles with the normal build and doesn't require a separate module. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasmith-hs
added a commit
that referenced
this pull request
Mar 16, 2026
The benchmark module was removed in PR #1018 because it was a disconnected directory that broke internal builds. This restores benchmarking as test-scoped JMH code within the existing project, so it compiles with the normal build and doesn't require a separate module. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes the benchmark "module" which uses Jinja and Liquid templates for performance testing. We never actually run this benchmark and, since it isn't an actual Maven submodule in this project, it leads to build errors on our internal build system.