Handle alternate is in exptest syntax#1079
Merged
jasmith-hs merged 2 commits intomasterfrom Jun 9, 2023
Merged
Conversation
This was not working properly because `in` is an extension operator as well as an exptest. This means you could do both: `1 in [1]` or `1 is in [1]`, with the former being an operator and the latter being parsed as an exptest We have several tokens which can be either exptests or operators so we can check all of them when using the alternate syntax too
boulter
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #973, there are several tokens which can be both operators and exptests.
This means you could do both:
1 in [1]or1 is in [1], with the former being an operator and the latter being parsed as an exptest. We were not handling all of these with the alternate exptest syntax, which looks likeexptest:in.evaluate(1, ____int3rpr3t3r____, [1]). We can use the same method to check if a symbol is a valid exptest symbol so that there is consistency.