Unwrap OutputTooBigException when wrapped in ELException#1086
Merged
jasmith-hs merged 2 commits intomasterfrom Jun 26, 2023
Merged
Unwrap OutputTooBigException when wrapped in ELException#1086jasmith-hs merged 2 commits intomasterfrom
jasmith-hs merged 2 commits intomasterfrom
Conversation
jasmith-hs
commented
Jun 23, 2023
Comment on lines
+248
to
+260
| } else if (e.getCause() != null && e.getCause() instanceof OutputTooBigException) { | ||
| interpreter.addError( | ||
| new TemplateError( | ||
| ErrorType.FATAL, | ||
| ErrorReason.OUTPUT_TOO_BIG, | ||
| ErrorItem.FUNCTION, | ||
| e.getCause().getMessage(), | ||
| null, | ||
| interpreter.getLineNumber(), | ||
| interpreter.getPosition(), | ||
| e | ||
| ) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can add a more specific error for OutputTooBigException here when it's thrown as the result of evaluating an ELExpression, such as calling a macro function with a very large output.