Remove meta context vars in regular for loop#1094
Merged
jasmith-hs merged 2 commits intomasterfrom Jul 25, 2023
Merged
Conversation
In eager execution, we'll use the default for loop logic first if the collection can be resolved so we need to remove the variables from the meta context variables as we do when running the EagerForTag's logic
(This test was not set up properly in #1088)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In eager execution, we'll use the default for loop logic first if the collection can be resolved so we need to remove the variables from the meta context variables as we do when running the EagerForTag's logic.
Basically, we weren't doing this when using the regular for loop's logic:
jinjava/src/main/java/com/hubspot/jinjava/lib/tag/eager/EagerForTag.java
Lines 187 to 190 in 8d879ea
Without this change, the eager execution output would look like:
contentwould not be reconstructed since it would remain considered a meta-context variable, but we need to temporarily remove that status when rendering a for loop{% for content in looper %}